[aarch64-port-dev ] RFR(S): 8213436: Obsolete UseMembar

[Doerr, Martin]

Hi again,

I had started the wrong build on s390. Please fix os_linux_s390.cpp: You removed one "}" too much. (No need for a new webrev.)

Best regards,
Martin


-----Original Message-----
From: Doerr, Martin 
Sent: Mittwoch, 7. November 2018 08:38
To: 'Mikael Vidstedt' <mikael.vidstedt at oracle.com>; Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
Cc: s390x-port-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
Subject: RE: RFR(S): 8213436: Obsolete UseMembar

Hi Mikael,

looks good and builds on PPC64 and s390.

Thanks,
Martin


-----Original Message-----
From: s390x-port-dev <s390x-port-dev-bounces at openjdk.java.net> On Behalf Of Mikael Vidstedt
Sent: Dienstag, 6. November 2018 22:01
To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
Cc: s390x-port-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
Subject: RFR(S): 8213436: Obsolete UseMembar


Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.

bug: https://bugs.openjdk.java.net/browse/JDK-8213436 <https://bugs.openjdk.java.net/browse/JDK-8213436>
webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/>

* Background (from jbs)

The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed.


* Testing

tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.


(Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...)

Cheers,
Mikael