[aarch64-port-dev ] RFR(trivial): 8163363: AArch64: Stack size in tools/launcher/Settings.java needs to be adjusted

Andrew Haley aph at redhat.com
Thu Apr 11 17:37:34 UTC 2019


On 4/11/19 12:13 PM, Patrick Zhang OS wrote:
> Could you please help review this, thanks.

Thanks.

The reader needs to be able to understand this strange number "448".

Imagine that you were a maintenance programmer coming across this
code. What does it mean? Consider how you might help the reader find
an explanation for this number. There is a good explanation in
https://bugs.openjdk.java.net/browse/JDK-8163363, the bug report, but
that doesn't help the reader, who does not know thw bug ID. Why not
add a link or a comment?

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the aarch64-port-dev mailing list