[aarch64-port-dev ] RFR(trivial): 8163363: AArch64: Stack size in tools/launcher/Settings.java needs to be adjusted

[Patrick Zhang OS]

Hi Andrew,

Thanks for your comments, I should have noticed this earlier, here is the update: http://cr.openjdk.java.net/~qpzhang/8163363/webrev.02 

Regards
Patrick

-----Original Message-----
From: Andrew Haley <aph at redhat.com> 
Sent: Friday, April 12, 2019 1:38 AM
To: Patrick Zhang OS <patrick at os.amperecomputing.com>; leonid.mesnik at oracle.com
Cc: aarch64-port-dev at openjdk.java.net
Subject: Re: RFR(trivial): 8163363: AArch64: Stack size in tools/launcher/Settings.java needs to be adjusted

On 4/11/19 12:13 PM, Patrick Zhang OS wrote:
> Could you please help review this, thanks.

Thanks.

The reader needs to be able to understand this strange number "448".

Imagine that you were a maintenance programmer coming across this code. What does it mean? Consider how you might help the reader find an explanation for this number. There is a good explanation in https://bugs.openjdk.java.net/browse/JDK-8163363, the bug report, but that doesn't help the reader, who does not know thw bug ID. Why not add a link or a comment?

--
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671