[aarch64-port-dev ] RFR (XS) 8229124: Revert disassembler.cpp changes

Aleksey Shipilev shade at redhat.com
Mon Aug 5 12:36:33 UTC 2019


On 8/5/19 1:22 PM, Andrew Haley wrote:
> On 8/5/19 11:22 AM, Andrew Dinn wrote:
>> I can see no reason for this change to be pushed up into jdk8u.
> 
> Indeed. Unless there's some extraordinarily good reason there should
> be no changes to shared code except the necessary ones guarded by
> ifdef AARCH64. That way we can be certain that the import into 8u
> cannot break anything.

I am a bit confused if this counts as approval to push to 8u-aarch64 or not. It seems to be! To be
clear: I am going to push this reversal to aarch64-port/jdk8u-shenandoah to minimize upstream
differences.

-- 
Thanks,
-Aleksey



More information about the aarch64-port-dev mailing list