[aarch64-port-dev ] [8u] RFR (M) 8228400: Remove built-in AArch64 simulator

[Andrew Dinn]

On 05/08/2019 11:38, Aleksey Shipilev wrote:
> On 8/5/19 11:42 AM, Andrew Dinn wrote:
>> There are also a few 'equivalent' removals but to code that has is now
>> in a different source file:
>>
>>   relocate of templateInterpreter code to templateInterpreterGenerator
>>   relocate of interpreter code to templateInterpreterGenerator
>>
>> The specific changes all look correct. So, I don't think there is any
>> problem with the patch ... well, except you have omitted  updates to
>> quite a few copyright headers :-]
> 
> Right. There no strict rule here: backporting work does not usually make additional copyright dates
> changes, unless the backported changeset demands it, or there is a conflict. Removals are even more
> awkward: consider what happens if the removed code had come in the single changeset. Then it is the
> usual practice to cleanly backout the complete changeset, even years later, keeping copyright dates
> untouched.
> 
> In the 8u-aarch64 case, I think we would need to bulk update copyright headers before 8u upstreaming
> anyway, so it does not hurt either way. We have also did not do updates in either jdk/jdk changeset
> (already pushed), jdk11u-dev webrev (can still be amended), or here. So, I'd rather keep the
> removals without additional changes. Can update the copyrights if you insist.

No, I'm fine if you leave the copyrights.

>> However, this left me wondering why these new changes had turned up. It
>> seems some of these new removals make sense but a couple appear to have
>> been missed from the corresponding 11u files:
>>
>>  3) os_linux_aarch64.cpp
> 
> Not following:
Ah, I was comparing your 8u deletions against the code currently in the
latest jdk11u and found the deleted code still present. However, I see
now that your check in to remove the changes from upstream jdk11 was
relative to jdk11u-dev and is not yet yet in jdk11u. So, please ignore
the comments about jdk11u (including copyrights). The patch is fine as is.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander