[aarch64-port-dev ] RFR (XS) 8229145: Revert TemplateTable::bytecode() visibility change

Andrew Dinn adinn at redhat.com
Tue Aug 6 07:56:36 UTC 2019


On 05/08/2019 19:09, Aleksey Shipilev wrote:
> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8229145
> 
> This is 8u-aarch64 specific thing, found again during 8u webrev scrubbing. See details in JIRA.
> 
> Reversal:
> 
> diff -r a979325732aa src/share/vm/interpreter/templateTable.hpp
> --- a/src/share/vm/interpreter/templateTable.hpp        Mon Aug 05 14:47:20 2019 +0200
> +++ b/src/share/vm/interpreter/templateTable.hpp        Mon Aug 05 20:09:05 2019 +0200
> @@ -102,10 +102,7 @@
> 
>    static Template*       _desc;                  // the current template to be generated
> - public:
>    static Bytecodes::Code bytecode()              { return _desc->bytecode(); }
> 
> - private:
>    static BarrierSet*     _bs;                    // Cache the barrier set.
> -
>   public:
>    //%note templates_1
> 
> Testing: {x86_64, aarch64} x {fastdebug, release}, hotspot_gc_shenandoah (for the lack of tier1)
This was needed at one point to allow the sim debugger to access
bytecodes and compute line numbers. It should go.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the aarch64-port-dev mailing list