[aarch64-port-dev ] Fwd: 8u-aarch64 : Backport 8163363: AArch64: Stack size in tools/launcher/Settings.java needs to be adjusted

Aleksey Shipilev shade at redhat.com
Tue Aug 6 16:35:25 UTC 2019


On 8/6/19 10:49 AM, Andrew Dinn wrote:
> The backport requires a minor tweak to the original patch as per the
> following webrev:
> 
>   http://cr.openjdk.java.net/~adinn/8163363-jdk8u/webrev.00/

*) I don't understand, why "ppc64le" case was added?

  78         if (getArch().equals("ppc64") || getArch().equals("ppc64le")) {

*) Original change has this comment, are we ignoring it?

 // Check the stack size logs printed by -XshowSettings to verify -Xss meaningfully.

Otherwise looks okay.

-- 
Thanks,
-Aleksey



More information about the aarch64-port-dev mailing list