[aarch64-port-dev ] Request for Approval: Backport patches to fix volatile access inconsistency

Andrew Dinn adinn at redhat.com
Mon Aug 12 09:26:51 UTC 2019


Hi Felix,

On 12/08/2019 09:43, Yangfei (Felix) wrote:
> Could I have a review of the following AArch64-specific backport to
> jdk8u-shenandoah please?

I think this patch would be worth backporting /even without/ the
problems you have encountered because it significantly reduces complexity.

> Webrev: http://cr.openjdk.java.net/~fyang/mm-8u-backport/webrev.00/

This patch looks good to me.

> Testing:
> 
> Jtreg tested with both 8u aarch64 fastdebug build and release build.
> 
> Passed Jcstress test with TieredCompilation option turned on & off.

Excellent.

I think this is ok to push. However, I would be happier if Roland could
also check it before you do that.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the aarch64-port-dev mailing list