[aarch64-port-dev ] 8233948: AArch64: Incorrect mapping between OptoReg and VMReg for high 64 bits of Vector Register

[Andrew Dinn]

Hi Joshua,

On 03/12/2019 12:26, Joshua Zhu (Arm Technology China) wrote:

>> Yes, of course. I updated webrev according to your review comments.
>> http://cr.openjdk.java.net/~jzhu/8233948/webrev.01/
> 
>>> Also, could you report what testing you did before and after your
>>> change (other than checking the dump output). You will probably need
>>> to repeat it to ensure these extra changes are ok.
>>
>> Oh, Sorry for that. I did not mention my testing in my previous mail (My
>> initial RFR mail is too long).
>> I ran full jtreg tests without new failure introduced.
>> I will re-run it against the new webrev and will let you know the results.
>> Thanks again for your review.
> 
> Testing: Passed hotspot_all_no_apps,  jdk_core and langtools:tier1 without new failure introduced.
> Please let me know if any comments. Thanks!

That looks good thanks.

Also, thank you for correcting my arithmetic when computing vect_words.

Approved for pushing.

regards,


Andrew Dinn
-----------