[aarch64-port-dev ] RFR 8135018: AARCH64: Missing memory barriers for CMS collector

[Andrew Haley]

On 12/13/19 8:48 AM, Liu Xin wrote:
> May I ask to review this backport?
> 
> bugs: https://bugs.openjdk.java.net/browse/JDK-8135018
> webrev: https://cr.openjdk.java.net/~xliu/8135018/00/webrev/
> 
> I can't cleanly apply the original patch, but it isn't hard to adapt it.
> This patch also brings UseCondCardMark to C1 and template interpreter,
> which is consistent with C2.
> 
> For validation part, I passed hotspot:tier1 test and jcstress with
> UseConcMarkSweepGC on an aarch64 machine.

That seems like a lot more than simply adding memory barriers. Looks like
the UseCondCardMark code is missing altogether.

I can't remember the history of this; I'm concerned that there may be other
missing hunks.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671