[aarch64-port-dev ] RFR (trivial): 8234228: AArch64: Clean up redundant temp vars in generate_compare_long_string_different_encoding

Andrew Dinn adinn at redhat.com
Wed Dec 18 17:27:32 UTC 2019


Hi Patrick,

On 10/12/2019 05:43, Patrick Zhang OS wrote:
> Could anyone help review this patch, thanks.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8234228  
> Webrev: http://cr.openjdk.java.net/~qpzhang/8234228/webrev.01
Thank you. This patch is good and ok to push.

It took me quite a while to figure out that this was a trivial patch
because the code is *abysmally* written and *even more* badly explained.
The worst aspect of it is the register naming which is extremely
misleading. However, it is terrible in many other respects. I think the
code really needs a respray and, perhaps, some reorganization to make it
clearer what is going on.

regards,


Andrew Dinn
-----------



More information about the aarch64-port-dev mailing list