[aarch64-port-dev ] RFC: 64 bit literal oops

Andrew Haley aph at redhat.com
Tue Feb 12 18:49:44 UTC 2019


On 2/11/19 1:27 PM, Stuart Monteith wrote:
> Thanks for your comments Nick.
> 
> I've updated the code with your comments:
>    http://cr.openjdk.java.net/~smonteith/oop64/webrev-20190211/

It's pretty close.

Two things:

I don't think you really have to calculate things like
NativeGeneralJump::instruction_size every time. They don't have to be
compile-time constants, they can be fields that you initialize
immediately after you've set Use64BitLiteralAddresses. If you do that
then you won't need to change so much code.

+// SRDM: Use64BitLiteralAddresses isn't initialized for the static _patch_info_offset to be used.

?

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the aarch64-port-dev mailing list