[aarch64-port-dev ] [NEW BUG]Missing LoadStore barrier in interpreter?

[Yangfei (Felix)]

Bug: https://bugs.openjdk.java.net/browse/JDK-8219635
Webrev: http://cr.openjdk.java.net/~fyang/8219635/webrev.00/ 
AArch64 8u-backport: http://cr.openjdk.java.net/~fyang/8219635-backport/webrev.00/ 

Both JCstress tested.  OK to push?

Thanks,
Felix

> 
> Thanks for reviewed this, Andrew.
> 
> Hi Felix,
> Could you please help sponsor this extra patch as well? It is quite similar as your
> previous one.
> I found JDK-8218185 has been resolved and the subject was for
> "putfield_or_static". Probably a new Jira ticket is needed for this
> "fast_storefield" and two issues are closely corelated. I have no commit
> permission so appreciate your help very much! (both jdk/jdk and jdk8u)
> 
> Regarding the tests, I have run jtreg jdk_core and jcstress on my aarch64
> platform, no problem found. Please help double check at your side too if possible.
> Thanks.
> 
> diff -r 2a78b2963793 src/hotspot/cpu/aarch64/templateTable_aarch64.cpp
> --- a/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Wed Feb 13 13:27:17
> 2019 +0100
> +++ b/src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Fri Feb 22 17:18:20
> 2019 +0800
> @@ -2981,7 +2981,7 @@
>    {
>      Label notVolatile;
>      __ tbz(r3, ConstantPoolCacheEntry::is_volatile_shift, notVolatile);
> -    __ membar(MacroAssembler::StoreStore);
> +    __ membar(MacroAssembler::StoreStore | MacroAssembler::LoadStore);
>      __ bind(notVolatile);
>    }