[aarch64-port-dev ] RFC: using gtest to test AArch64 MacroAssembler

[Andrew Haley]

On 2/28/19 9:49 AM, Nick Gasson wrote:
> Hi Andrew,
> 
> On 28/02/2019 17:38, Andrew Haley wrote:
>>
>> I'll address the rest of your post later, but one thing occurs to me: you
>> don't mention jcstress anywhere in this message.
> 
> Yes that's true, and I ran jcstress at the time. But jcstress is 
> checking your implementation is correct wrt. the Java memory model, 
> rather than some implementation details. You could replace fast_lock and 
> fast_unlock with something that just set the NE flag and it would still 
> pass jcstress (because it would always fall through to the slow path), 
> but that's probably not what was intended...

I'll pass this one back to you: which classes of bugs in locks would
this new test *not* detect? Are they important? What could be done
about that?

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671