[aarch64-port-dev ] RFR: 8216350: AArch64: monitor unlock fast path not called

[Nick Gasson (Arm Technology China)]

Thanks Derek! Is there anyone who can help me push this? (BTW in the 
last webrev I removed the Contributed-by line and added my hg username, 
hope this is correct...)

Nick

On 17/01/2019 03:44, Derek White wrote:
> Hi Nick,
> 
> Looks good to me!
> 
>   - Derek
> 
>> -----Original Message-----
>> From: Nick Gasson (Arm Technology China) <Nick.Gasson at arm.com>
>> Sent: Thursday, January 10, 2019 9:37 PM
>> To: Andrew Haley <aph at redhat.com>; Derek White
>> <derekw at marvell.com>; hotspot-compiler-dev at openjdk.java.net compiler
>> <hotspot-compiler-dev at openjdk.java.net>
>> Cc: nd <nd at arm.com>; aarch64-port-dev at openjdk.java.net
>> Subject: [EXT] Re: [aarch64-port-dev ] RFR: 8216350: AArch64: monitor
>> unlock fast path not called
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> Hi all,
>>
>> On 09/01/2019 17:23, Andrew Haley wrote:
>>>
>>> HotSpot policy is that we can do minor cleanups as we go along:
>>> experience has shown that unless you do so, cruft tends to accumulate.
>>> These cleanups are OK for this patch.
>>>
>>
>> Please see the updated webrev here:
>>
>> http://cr.openjdk.java.net/~ngasson/8216350/webrev.1/
>>
>> Includes cleanups according to Derek's comments and updated the copyright
>> year (thanks Felix).
>>
>>> 4)  Slightly better comment for last instruction of fast_unlock (and
>> explicitly use zr).
>>>      __ stlr(zr, tmp); // set unowned
>>
>> Note I needed to change the definition of load_store_exclusive to allow ZR
>> here. I've checked that this is OK for the other instructions that use this.
>>
>> Thanks,
>> Nick