[aarch64-port-dev ] RFR (M) 8228400: Remove built-in AArch64 simulator

Aleksey Shipilev shade at redhat.com
Sun Jul 28 20:03:10 UTC 2019


On 7/28/19 6:52 PM, Dmitry Samersoff wrote:
> 1. Do I understand correctly that we no longer use number_of_arguments
> parameter?

Yes, I think so.

> Should we remove it and version of call_VM_leaf on l. 1430

Maybe? I would leave it as follow-up. The change would be local and easy to test separately.
Unfortunately, it would invalidate lots of testing already done for this patch. I can see how much
hassle that would be, and maybe fold that improvement here...

> 2. Do we still need to stp/ldp rscratch1?

I think so. AFAIU, it caller-saves rscratch1+rmethod, which is what call_VM_leaf_base might expect?
The call is still pretty much there, so calling convention should be kept intact.

-Aleksey



More information about the aarch64-port-dev mailing list