[aarch64-port-dev ] RFR (XS) 8228716: Revert InstanceKlass::print_on debug additions

Aleksey Shipilev shade at redhat.com
Mon Jul 29 10:33:38 UTC 2019


Continuing to scrub difference against 8u upstream. This bit shows up:

https://builds.shipilev.net/patch-openjdk-jdk8-aarch64/hotspot/src/share/vm/oops/instanceKlass.cpp.sdiff.html

I looked around 8u, 11u, 14 code, and there is no such block anywhere near, so this is not a missing
backport, but rather the aarch64 development addition. I think it should be reverted:
  https://bugs.openjdk.java.net/browse/JDK-8228716

Patch:

diff -r 6e4f992250b5 src/share/vm/oops/instanceKlass.cpp
--- a/src/share/vm/oops/instanceKlass.cpp       Fri Jan 10 11:31:09 2014 +0000
+++ b/src/share/vm/oops/instanceKlass.cpp       Mon Jul 29 12:31:44 2019 +0200
@@ -3116,21 +3116,4 @@
   Klass::print_on(st);

-  st->print(BULLET"primary supers:    ");
-  for (juint i = 0; i < Klass::primary_super_limit(); i++) {
-    if (_primary_supers[i]) {
-      _primary_supers[i]->name()->print_value_on(st);
-      st->print("   ");
-    }
-  }
-  st->cr();
-
-  st->print(BULLET"secondary supers:    ");
-  int cnt = secondary_supers()->length();
-  for (int i = 0; i < cnt; i++) {
-    secondary_supers()->at(i)->print_value_on(st);
-      st->print("   ");
-  }
-  st->cr();
-
   st->print(BULLET"instance size:     %d", size_helper());                        st->cr();
   st->print(BULLET"klass size:        %d", size());                               st->cr();


Testing: x86_64 build

-- 
Thanks,
-Aleksey



More information about the aarch64-port-dev mailing list