[aarch64-port-dev ] RFR (XS) 8228718: Revert incorrect backport of JDK-8129757 to 8-aarch64

Aleksey Shipilev shade at redhat.com
Mon Jul 29 11:29:13 UTC 2019


Bug:
 https://bugs.openjdk.java.net/browse/JDK-8228718

In current aarch64-port code, there is a backport of JDK-8129757:
 https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/f39e296fb4c5

The backport is there to fit the changed signature of SharedRuntime::complete_monitor_unlocking_C
that is introduced by JDK-8073165, that is not available in 8u. Current signature of
SharedRuntime::complete_monitor_unlocking_C in 8-aarch is:

src/share/vm/opto/runtime.hpp
180: static void complete_monitor_unlocking_C(oopDesc* obj, BasicLock* lock);

src/share/vm/runtime/sharedRuntime.hpp
504: static void complete_monitor_unlocking_C(oopDesc* obj, BasicLock* lock);

This means the backport is actually incorrect, and we should revert it. Right?

Fix:
 http://cr.openjdk.java.net/~shade/8228718/webrev.01/

Testing: aarch64 build, hotspot_gc_shenandoah (for the lack of tier1 yet)

-- 
Thanks,
-Aleksey



More information about the aarch64-port-dev mailing list