[aarch64-port-dev ] RFR (XS) 8228747: Revert "unused" attribute from test_arraycopy_func

Andrew Dinn adinn at redhat.com
Tue Jul 30 08:09:20 UTC 2019


On 29/07/2019 20:34, Aleksey Shipilev wrote:
> RFE:
>   https://bugs.openjdk.java.net/browse/JDK-8228747
> 
> Simple reversal of the very old change. This eliminates divergence from 8u upstream.
> 
> Fix:
> 
> diff -r 7ea73682a481 src/share/vm/runtime/stubRoutines.cpp
> --- a/src/share/vm/runtime/stubRoutines.cpp     Mon Jul 29 21:15:23 2019 +0200
> +++ b/src/share/vm/runtime/stubRoutines.cpp     Mon Jul 29 21:34:13 2019 +0200
> @@ -187,7 +187,4 @@
> 
>  // simple tests of generated arraycopy functions
> -#ifdef __GNUC__
> -static void test_arraycopy_func(address func, int alignment) __attribute__((unused));
> -#endif
>  static void test_arraycopy_func(address func, int alignment) {
>    int v = 0xcc;
> 
> 
> Testing: x86_64 (gcc 7.4), aarch64 (gcc 4.8.5) builds;
Looks good.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the aarch64-port-dev mailing list