[aarch64-port-dev ] [11u] RFR 8228400: Remove built-in AArch64 simulator

[Aleksey Shipilev]

On 7/31/19 8:21 PM, Andrew Haley wrote:
> On 7/31/19 6:51 PM, Aleksey Shipilev wrote:
>> Testing: aarch64 tier1, tier2; eyeballing differences against jdk/jdk changeset
> 
> No. I don't think that the removal of the built-in simulator should be
> backported.  

I thought we would remove it in 8u-aarch64, in preparation for eventual upstreaming. It that case,
it makes sense to have all releases share the same code shape to simplify future backporting.
Simulator is already removed in 14, and assuming we are doing it in 8u-aarch64, 11u would be the
only release left with the built-in simulator.

Removals in 11u and 8u-aarch64 were the plan all along:

"If not, should we remove it to reduce the codebase? It is present in all JDK releases, including 11
and 13. We could start there, and backport all the way down to 8u."
  https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-July/007688.html

"I am planning to backport it to 11u and 8u-aarch64 too."
  https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2019-July/007703.html

> It doesn't win anything significant and it carries a nonzero risk.

I would call removing this much effectively dead code rather significant win for maintainability:
  2350 lines changed: 45 ins; 2269 del; 36 mod; 50803 unchg

-- 
Thanks,
-Aleksey