[aarch64-port-dev ] RFR: 8222412 - AARCH64: multiple instructions encoding issues

[Dmitrij Pochepko]

On 07/06/2019 7:22 PM, Andrew Haley wrote:
> On 6/7/19 5:02 PM, Dmitrij Pochepko wrote:
>> On 07/06/2019 6:29 PM, Andrew Haley wrote:
>>> On 6/7/19 3:36 PM, Dmitrij Pochepko wrote:
>>>> please review patch for JDK-8222412 - AARCH64: multiple instructions
>>>> encoding issues
>>>>
>>>> I updated python script aarch64-asmtest.py used for automatic tests
>>>> generation and requesting review for the issues found by eyeballing and
>>>> by the updated script.
>>>>
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8222412
>>>>
>>>> Webrev of instruction encoding cumulative fix:
>>>> http://cr.openjdk.java.net/~dpochepk/8222412/webrev.02/
>>>> (assembler_aarch64.cpp part consists of automatically generated
>>>> instructions only).
>>>>
>>>> Updated script:
>>>> http://cr.openjdk.java.net/~dpochepk/8222412/webrev.02/aarch64-asmtest.py
>>> Excellent. That's a thorough piece of work.
>>>
>>> One thing that I did not check: does this patch cover all of the
>>> instructions that we generate?
>>>
>>> Thank you.
>> I only added test cases to cover instructions, which generation logic
>> was changed by this patch (positive cases only, because negative cases
>> triggers asserts).
>>
>> There is still a number of instructions (mostly SIMD), which are not
>> generated by this testing mechanism. It should probably be a separate
>> test-coverage-only effort. Do we want it in future?
> It's certainly not essential but might be nice.
>
> Patch is approved.
>
Thank you for review!