[aarch64-port-dev ] RFR: JDK-8214527 AArch64: ZGC for Aarch64

[Andrew Dinn]

On 13/06/2019 13:24, Stuart Monteith wrote:
> Yes, let's leave the renaming until JDK14 - I was aiming for the patch
> to make JDK13, but we'll see.
> 
> The registers are being defined here in order for the LoadBarrier for
> ZGC in z_aarch64.ad to spill them while it does the barrier
> correction. I had thought the vector registers would need to have
> their full 128 bits spilled, if they happened to be live - this is the
> same as what is done for z_x86_64.ad .

Well, as far as I understand it: if the registers happened to be live
with 128 bit data loaded by C2 generated code then they should get
spilled as 128 bits values when an instruction is generated that KILLs
the bottom 64 bits.

Of course, there is also the question of what C2 ought to do to preserve
incoming values in callee-save float registers. I am not sure of this
but I thought callers could only expect 64 bit float register data to be
saved by the callee. Is that right? Or did I make that last bit up?

> I'm currently trying to catch the registers spilled with the current
> code - not with much luck so far. The autovectorization is sensitive
> enough such that that is proving difficult (as aph pointed out).
Yes, indeed. I didn't think it would be simple.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander