[aarch64-port-dev ] JDK 13 AArch64 issues to backport

[Andrew John Hughes]

On 17/06/2019 13:29, Aleksey Shipilev wrote:
> Hi,
> 
> I was reading through the JDK 13 changelist:
>   https://builds.shipilev.net/backports-monitor/release-notes-13.txt
> 
> ...and there are some AArch64 issues that probably deserve backports to 8u and 11u as well.
> 
> These are:
>   8215879: Aarch64: ReservedStackAccess may leave stack guard in inconsistent state
>   8217368: AArch64: C2 recursive stack locking optimisation not triggered
>   8209413: AArch64: NPE in clhsdb jstack command
>   8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero
> length on AARCH64
>   8219993: AArch64: Compiled CI stubs are unsafely modified
>   8221995: AARCH64: problems with CAS instructions encoding
>   8205421: AARCH64: StubCodeMark should be placed after alignment
>   8213134: AArch64: vector shift failed with MaxVectorSize=8
>   8221658: aarch64: add necessary predicate for ubfx patterns
>   8163363: AArch64: Stack size in tools/launcher/Settings.java needs to be adjusted
>   8222785: aarch64: add necessary masking for immediate shift counts
>   8223020: aarch64: expand minI_rReg and maxI_rReg patterns into separate instructions
>   8215961: jdk/jfr/event/os/TestCPUInformation.java fails on AArch64
>   8218185: aarch64: missing LoadStore barrier in TemplateTable::putfield_or_static
>   8219635: aarch64: missing LoadStore barrier in TemplateTable::fast_storefield
>   8221220: AArch64: Add StoreStore membar explicitly for Volatile Writes in TemplateTable
>   8215792: AArch64: String.indexOf generates incorrect result
>   8218966: AArch64: String.compareTo() can read memory after string
>   8216350: AArch64: monitor unlock fast path not called
>   8219006: AArch64: Register corruption in slow subtype check
>   8219011: Implement MacroAssembler::warn method on AArch64
>   8219698: aarch64: SIGILL triggered when specifying unsupported hardware features
> 
> I marked them with "8-aarch64" and "11" as affected versions, where applicable. If you will, please
> consider backporting them.
> 
> Also, put "redhat-interest" to get them on Red Hat's people backporting radars:
>   https://builds.shipilev.net/backports-monitor/label-actionable-redhat-interest.txt
> 

A few of these have already been backported:

For 11u:

changeset:   52543:0402d1e99f13
user:        ngasson
date:        Tue Mar 12 10:48:02 2019 +0800
summary:     8216350: AArch64: monitor unlock fast path not called
https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/0402d1e99f13

For aarch64/shenandoah-jdk8u:

changeset:   10839:f98005f3f634
tag:         aarch64-shenandoah-jdk8u201-b11
user:        fyang
date:        Mon Feb 11 17:09:17 2019 +0800
summary:     8218185: aarch64: missing LoadStore barrier in
TemplateTable::putfield_or_static
https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/f98005f3f634

changeset:   10891:7b7da2a4e83c
parent:      10889:d0bf0d3e0b2e
user:        fyang
date:        Mon Feb 25 19:09:02 2019 +0800
summary:     8219635: aarch64: missing LoadStore barrier in
TemplateTable::fast_storefield
https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/7b7da2a4e83c

changeset:   10893:06dccf7653c0
tag:         aarch64-shenandoah-jdk8u201-b13
user:        qpzhang
date:        Mon Mar 25 18:48:15 2019 +0800
summary:     8221220: AArch64: Add StoreStore membar explicitly for
Volatile Writes in TemplateTable
https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/06dccf7653c0

For icedtea7-2.6:

changeset:   6697:65b809089544
tag:         icedtea-2.6.17pre01
user:        fyang
date:        Wed Feb 20 14:43:02 2019 +0000
summary:     8218185, PR3669: aarch64: missing LoadStore barrier in
TemplateTable::putfield_or_static
https://icedtea.classpath.org/hg/release/icedtea7-forest-2.6/hotspot/rev/65b809089544

changeset:   6717:4a6c33ce009c
user:        fyang
date:        Tue Apr 16 04:38:49 2019 +0100
summary:     8219635, PR3726: aarch64: missing LoadStore barrier in
TemplateTable::fast_storefield
https://icedtea.classpath.org/hg/release/icedtea7-forest-2.6/hotspot/rev/4a6c33ce009c

changeset:   6718:6e7512a54bc6
tag:         icedtea-2.6.18
user:        qpzhang
date:        Tue Apr 16 04:44:36 2019 +0100
summary:     8221220, PR3726: AArch64: Add StoreStore membar explicitly
for Volatile Writes in TemplateTable
https://icedtea.classpath.org/hg/release/icedtea7-forest-2.6/hotspot/rev/6e7512a54bc6
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew