[aarch64-port-dev ] RFR (trivial): 8215976: backport a patch to jdk8u-shenandoah/jdk, fix gmtime_r declaration conflicts in zip.cpp with linux header files

[Patrick Zhang OS]

Please help review this backport request, thanks.

http://cr.openjdk.java.net/~qpzhang/rawpatches/gmtime_aarch64.patch.txt 

Regards
Patrick

-----Original Message-----
From: aarch64-port-dev <aarch64-port-dev-bounces at openjdk.java.net> On Behalf Of Patrick Zhang OS
Sent: Tuesday, March 5, 2019 3:58 PM
To: aarch64-port-dev at openjdk.java.net
Subject: [aarch64-port-dev ] RFR (trivial): 8215976: backport a patch to jdk8u-shenandoah/jdk, fix gmtime_r declaration conflicts in zip.cpp with linux header files

Hi Reviewers,

This issue (belongs to core libs) was exposed by building OpenJDK with ampere toolchains (gcc 8.2) on an aarch64 platform, and the fix has been verified on jdk/submit, pushed into jdk/jdk, backported to jdk8u-dev respectively, see below for details.
May I request to backport it to aarch64-port/jdk8u-shenandoah/jdk as well? 

https://bugs.openjdk.java.net/browse/JDK-8215976, http://hg.openjdk.java.net/jdk/jdk/rev/06862c019f3f   
https://bugs.openjdk.java.net/browse/JDK-8217901, http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/db7a698be165
Tests: this patch does not impact functions, build jdk/jdk has been verified at jdk/submit, build aarch64 verified at ampere platforms.

Attached is the diff, please help review, thanks.

Regards
Patrick

-----Original Message-----
From: aarch64-port-dev <aarch64-port-dev-bounces at openjdk.java.net> On Behalf Of Patrick Zhang OS
Sent: Wednesday, February 27, 2019 1:26 PM
To: aarch64-port-dev at openjdk.java.net
Subject: Re: [aarch64-port-dev ] Request to port a patch to aarch64-port/jdk8u-shenandoah, fix gmtime_r declaration conflicts in zip.cpp with linux header files

Hi

Can I ask for porting this (simple) patch from jdk8u-dev to aarch64-port/jdk8u-shenandoah? I supposed it would be in via 'bulk merge' but haven't found so in the latest merge. 
Please kindly approve this, thanks in advance.

http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/db7a698be165
JBS: https://bugs.openjdk.java.net/browse/JDK-8217901
(Btw, I found "Fix Version/s: openjdk8u211", when will this accutally happen? April release? or already done? I am confused here...)

Regards
Patrick

-----Original Message-----
From: Patrick Zhang
Sent: Tuesday, January 29, 2019 11:29 AM
To: 'Andrew Hughes' <gnu.andrew at redhat.com>; Andrew Haley <aph at redhat.com>
Cc: aarch64-port-dev at openjdk.java.net
Subject: RE: [aarch64-port-dev ] Request to cherry-pick JDK-8215976, fix gmtime_r declaration conflicts in zip.cpp with linux header files

Many thanks for the help. I saw it is in jdk8u now and suppose will be in aarch64-port/jdk8u-shenandoah soon.

Regards
Patrick

-----Original Message-----
From: Andrew Hughes <gnu.andrew at redhat.com>
Sent: Wednesday, January 23, 2019 11:40 PM
To: Andrew Haley <aph at redhat.com>
Cc: Patrick Zhang <patrick at os.amperecomputing.com>; aarch64-port-dev at openjdk.java.net
Subject: Re: [aarch64-port-dev ] Request to cherry-pick JDK-8215976, fix gmtime_r declaration conflicts in zip.cpp with linux header files

On Wed, 23 Jan 2019 at 09:37, Andrew Haley <aph at redhat.com> wrote:
>
> On 1/23/19 3:18 AM, Patrick Zhang wrote:
> > Would there be any proper process to follow, please let me know. Appreciate your help.
>
> I'm fine with this being put into the aarch64-port/jdk8u-shenandoah 
> port, but it should be sent to jdk8u-dev.
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

Please get the fix into upstream jdk8u, via the 8u-dev list, and we will then pick it up in aarch64-port/jdk8u-shenandoah when we merge.

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222