[aarch64-port-dev ] RFR 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code

Zhengyu Gu zgu at redhat.com
Mon Nov 4 18:18:38 UTC 2019



On 11/4/19 12:38 PM, Andrew Haley wrote:
> On 11/4/19 5:33 PM, Zhengyu Gu wrote:
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8233401/webrev.01/index.html
>>
>> Okay now?
> AArch64 still says
> 
>   void ShenandoahBarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type,
>                                               Register dst, Address src, Register tmp1, Register tmp_thread) {
> 
> instead of
> 
>   void ShenandoahBarrierSetAssembler::load_at(MacroAssembler* masm, DecoratorSet decorators, BasicType type,
>                                               Register dst, Address src, Register, Register) {

They are still needed for calling super class's load_at(). Even though, 
they are not used there neither.

   // 1: non-reference load, no additional barrier is needed
   if (!is_reference_type(type) ) {
     BarrierSetAssembler::load_at(masm, decorators, type, dst, src, 
tmp1, tmp_thread);
     return;
   }


-Zhengyu

> 


More information about the aarch64-port-dev mailing list