[aarch64-port-dev ] RFR 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code

Zhengyu Gu zgu at redhat.com
Tue Nov 5 12:33:19 UTC 2019



On 11/5/19 3:52 AM, Andrew Haley wrote:
> On 11/4/19 6:23 PM, Zhengyu Gu wrote:
>>> They are still needed for calling super class's load_at(). Even though,
>>> they are not used there neither.
> 
> Aha! Sorry, I missed that.
> 
>> Or I should say, they are not used there right now, but may be used in
>> future ...
> 
> So add them in the future, surely. All you're doing by passing unused
> args is confusing the reader. It definitely succeeded with me...
> 
Sorry, I should just remove 'unused' comments. Okay with you?


Thanks,

-Zhengyu




More information about the aarch64-port-dev mailing list