[aarch64-port-dev ] RFR: aarch64: minor improvements of atomic operations

[Andrew Haley]

On 11/5/19 6:20 AM, Yangfei (Felix) wrote:
> Please review this small improvements of aarch64 atomic operations.
> This eliminates the use of full memory barriers.
> Passed tier1-3 testing.

No, rejected.

Patch also must go to hotspot-dev.

Are you sure this is safe? The HotSpot internal barriers are specified
as being full two-way barriers, which these are not. Tier1 testing
really isn't going to do it. Now, you might argue that none of the
uses in HotSpot actually require anything stronger that acq/rel, but
good luck proving that.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671