[aarch64-port-dev ] RFR(S): 8234791: Fix Client VM build for x86_64 and AArch64

[Pengfei Li (Arm Technology China)]

Hi Andrew Dinn,

> Your explanation sounds correct and the change to arguments.cpp looks
> good.
> 
> Can you explain why you have modified sharedRuntime_aarch64.cpp to
> include nativeInst_aarch64.hpp? I don't see any other change in the source
> file that would make this necessary.

Thanks for review. There is another build error below after I fixed arguments.cpp.

For target hotspot_variant-client_libjvm_objs_sharedRuntime_aarch64.o:
....../src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:2836:22: error: 'NativeInstruction' has not been declared
__ add(r20, r20, NativeInstruction::instruction_size);

We see that sharedRuntime_aarch64.cpp uses NativeInstruction but doesn't include nativeInst_aarch64.hpp.
There is no error in Server VM build because the header file is included indirectly from some C2 file.
But for Client VM build where C2 files are not in, this error occurs.

--
Thanks,
Pengfei