[aarch64-port-dev ] RFR(S): 8232591: AArch64: Add missing match rules for smaddl, smsubl and smnegl

[Andrew Haley]

On 10/25/19 2:11 PM, Andrew Haley wrote:
> On 10/22/19 10:50 AM, Pengfei Li (Arm Technology China) wrote:
>> I don't find any jtreg cases testing these. I've created a jtreg and uploaded a new webrev, please see
>> http://cr.openjdk.java.net/~pli/rfr/8232591/webrev.01/
>>
>> Is it good enough?
> 
> Yes, I think so. It's enough to make sure that the corner cases and overflows
> are handled correctly. We have to be sure that we really are generating the
> correct instructions. Thanks.

By the way, I also checked with this Case:

        new Case(0xffffffff,  0xffffffff, 0xffffffffeL << 32,   0xfffffffe00000001L,   0xfffffffdffffffffL,      -1L),

which tests the carries frm highpart to lowpart.
(It's the result of 0xffffffff * 0xffffffff == 0xfffffffe00000001.)

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671