[aarch64-port-dev ] RFR: heapbase register can be allocated in compressed mode

Pengfei Li Pengfei.Li at arm.com
Mon Apr 20 10:10:05 UTC 2020


Hi Andrew,

> Sorry, no it isn't fine. Please get rid of this hunk:
> 
> --- old/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp	2020-
> 04-14 21:18:52.009758661 +0800
> +++ new/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp	2020-
> 04-14 21:18:51.785764043 +0800
> @@ -2185,6 +2185,10 @@
>  #if 0
>    assert (UseCompressedOops || UseCompressedClassPointers, "should be
> compressed");
>    assert (Universe::heap() != NULL, "java heap should be initialized");
> +  if (!UseCompressedOops || Universe::ptr_base() == NULL) {
> +    // rheapbase is allocated as general register
> +    return;
> +  }
>    if (CheckCompressedOops) {
>      Label ok;
>      push(1 << rscratch1->encoding(), sp); // cmpptr trashes rscratch1

Oh. It's already pushed just now. According to the process, we may need Wei to create another JBS to backout that part?

--
Thanks,
Pengfei



More information about the aarch64-port-dev mailing list