[aarch64-port-dev ] RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic

[Yangfei (Felix)]

Hi,

> -----Original Message-----
> From: Andrew Haley [mailto:aph at redhat.com]
> Sent: Friday, July 31, 2020 11:56 PM
> To: Yangfei (Felix) <felix.yang at huawei.com>; hotspot-runtime-
> dev at openjdk.java.net
> Cc: aarch64-port-dev at openjdk.java.net
> Subject: Re: RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
> 
> On 7/31/20 10:57 AM, Yangfei (Felix) wrote:
> > Since this will not be enabled when the hardware feature is missing,  do
> you think we need any more changes?
> 
> I do. I do not want the accelerator intrinsic to be auto-enabled until it has
> been tested on hardware.

OK.  I simply comment out the following code changes in vm_version_aarch64.cpp:

 393   if (UseSHA && (auxv & HWCAP_SHA512)) {
 394     // Do not auto-enable UseSHA512Intrinsics until it has been fully tested on hardware
 395     // if (FLAG_IS_DEFAULT(UseSHA512Intrinsics)) {
 396       // FLAG_SET_DEFAULT(UseSHA512Intrinsics, true);
 397     // }
 398   } else if (UseSHA512Intrinsics) {

Once this has been fully tested on real hardware, it will be easy to auto-enable.

New webrev: http://cr.openjdk.java.net/~fyang/8165404/webrev.01/ 

Thanks,
Felix