[aarch64-port-dev ] RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC

Tue Aug 4 19:41:39 UTC 2020

Looks good to me!

-----Original Message-----
From: aarch64-port-dev <aarch64-port-dev-retn at openjdk.java.net> On Behalf Of Monica Beckwith
Sent: Tuesday, August 4, 2020 12:04 PM
To: Monica Beckwith <Monica.Beckwith at microsoft.com>; Stuart Monteith <stuart.monteith at arm.com>; aarch64-port-dev at openjdk.java.net
Subject: [EXT] Re: [aarch64-port-dev ] RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC

External Email

----------------------------------------------------------------------
I have incorporated your comments and added the 'reviewed-by' information.

JBS: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8248663&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=uB6tOAbHkzy_1rd_01j5dBADE-1lSlMJOz__BC-mmRw&s=IMo-ICFJUvQ2jI4kbejshIbA4W0fIEj2x2pKQLnWwP4&e=
Webrev: https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Embeckwit_8248663_webrev.01_&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=uB6tOAbHkzy_1rd_01j5dBADE-1lSlMJOz__BC-mmRw&s=UjDK1dnOT1PMXK26CAeOfU7cK0Ej6eKTcOwZgrK5g4U&e= 

Thanks again.

-Monica

-----Original Message-----
From: aarch64-port-dev <aarch64-port-dev-retn at openjdk.java.net> On Behalf Of Monica Beckwith
Sent: Friday, July 24, 2020 12:01 PM
To: Stuart Monteith <stuart.monteith at arm.com>; aarch64-port-dev at openjdk.java.net
Subject: Re: [aarch64-port-dev ] RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC

Hi both, thanks. The comments are put in place as I was hoping that down the line, if someone plans to revert the changes, then they have a context that MSVC is going to have issues again. But I do see Stuart's point: to a new reader, the comment by itself may seem strange.

-Monica

-----Original Message-----
From: aarch64-port-dev <aarch64-port-dev-retn at openjdk.java.net> On Behalf Of Stuart Monteith
Sent: Friday, July 24, 2020 10:52 AM
To: aarch64-port-dev at openjdk.java.net
Subject: Re: [aarch64-port-dev ] RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC

Hello,
	I don't think "// `DIFFERENCE` is an MSVC macro" is a useful comment, as DIFFERENCE has been removed. It makes sense in context.

I like the "mvn" comment, as that does help.

Thanks,
	Stuart

On 24/07/2020 16:26, Derek White wrote:
> Hi Monica,
> 
> Looks good!
> 
> Style comment - I'm not sure if the comments about MSVC in c2_MacroAssembler_aarch64.cpp and macroAssembler_aarch64.hpp are strictly necessary, but I don't have a strong opinion.
> 
> - Derek
> 
> -----Original Message-----
> From: aarch64-port-dev <aarch64-port-dev-retn at openjdk.java.net> On 
> Behalf Of Monica Beckwith
> Sent: Friday, July 24, 2020 11:10 AM
> To: aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers 
> <hotspot-dev at openjdk.java.net>
> Cc: openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
> Subject: [EXT] Re: [aarch64-port-dev ] RFR/Feedback(S) 8248663: 
> AArch64: Avoid existing macros/keywords of MSVC
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hello all - could I please get feedback on the following changes?
> 
> Copying clean links here again:
> JBS: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__nam06.safelinks.p
> rotection.outlook.com_-3Furl-3Dhttps-253A-252F-252Furld&d=DwIGaQ&c=nKj
> Wec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=uB
> 6tOAbHkzy_1rd_01j5dBADE-1lSlMJOz__BC-mmRw&s=uW7I8hTNYFXMAU4Z0U21Vrlu4O
> KfV0bP5ZBUpw5oIYk&e= 
> efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__bugs.openjdk.java.net
> _browse_JDK-2D8248663%26d%3DDwIFAg%26c%3DnKjWec2b6R0mOyPaz7xtfQ%26r%3D
> gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk%26m%3DVRH-lUr10_r9nlZWYqA0
> RgBcfPqzSx1Pz12OUdX6TQc%26s%3D-1BKo7dfMxAqI0c80NeOgXxY4Kig4HV6N_342REu
> HTc%26e%3D&data=02%7C01%7Cmonica.beckwith%40microsoft.com%7C907a0f
> d42b2d4b0b7e0808d82fe99ab4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%
> 7C637312027651961479&sdata=trv1jqoIr7HIWJV7ZCjyppC5a9%2FTldLemsNHj
> ztpDHM%3D&reserved=0
> Webrev: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__nam06.safelinks.p
> rotection.outlook.com_-3Furl-3Dhttps-253A-252F-252Furld&d=DwIGaQ&c=nKj
> Wec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=uB
> 6tOAbHkzy_1rd_01j5dBADE-1lSlMJOz__BC-mmRw&s=uW7I8hTNYFXMAU4Z0U21Vrlu4O
> KfV0bP5ZBUpw5oIYk&e=
> efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__cr.openjdk.java.net_-
> 7Embeckwit_8248663_webrev.00_%26d%3DDwIFAg%26c%3DnKjWec2b6R0mOyPaz7xtf
> Q%26r%3DgW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk%26m%3DVRH-lUr10_r9
> nlZWYqA0RgBcfPqzSx1Pz12OUdX6TQc%26s%3DFDH2O5mbnaWupPL9AiRQqpDl1glFLtf1
> vP02BQvfmXM%26e%3D&data=02%7C01%7Cmonica.beckwith%40microsoft.com%
> 7C907a0fd42b2d4b0b7e0808d82fe99ab4%7C72f988bf86f141af91ab2d7cd011db47%
> 7C1%7C0%7C637312027651961479&sdata=koVux%2FcolGpd4FCHL%2FUmYcJEzol
> g3huK7ulwLBgxlwc%3D&reserved=0
> 
> Thanks,
> Monica
> 
> 
> -----Original Message-----
> From: Monica Beckwith <Monica.Beckwith at microsoft.com>
> Sent: Thursday, July 16, 2020 2:40 PM
> To: aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers 
> <hotspot-dev at openjdk.java.net>
> Cc: openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
> Subject: RFR/Feedback(S) 8248663: AArch64: Avoid existing 
> macros/keywords of MSVC
> 
> These changes are concerning specific macro names or keywords used by MSVC. E.g. `mvn,` `DIFFERENCE` and `far.` We are proposing to change those in the shared code.
> 
> JBS: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__nam06.safelinks.p
> rotection.outlook.com_-3Furl-3Dhttps-253A-252F-252Furld&d=DwIGaQ&c=nKj
> Wec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=uB
> 6tOAbHkzy_1rd_01j5dBADE-1lSlMJOz__BC-mmRw&s=uW7I8hTNYFXMAU4Z0U21Vrlu4O
> KfV0bP5ZBUpw5oIYk&e= 
> efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__nam06.safelinks.prote
> ction.outlook.com_-3Furl-3Dhttps-253A-252F-252Fbugs.openjdk.java.net-2
> 52Fbrowse-252FJDK-2D8248663-26amp-3Bdata-3D02-257C01-257CMonica.Beckwi
> th-2540microsoft.com-257C35f78927e915431fbf4d08d829bfff9d-257C72f988bf
> 86f141af91ab2d7cd011db47-257C1-257C0-257C637305251886976662-26amp-3Bsd
> ata-3DjGxT7lMPEEg7iJPgoflgEByvHnuZEof-252BBqPrGfQhulg-253D-26amp-3Bres
> erved-3D0%26d%3DDwIFAg%26c%3DnKjWec2b6R0mOyPaz7xtfQ%26r%3DgW0hANMfJfyE
> LYt_X2mceubwzCNjT0vmaU97kngYUJk%26m%3DVRH-lUr10_r9nlZWYqA0RgBcfPqzSx1P
> z12OUdX6TQc%26s%3D6CkQlp-iwC2nuFgVxfwZjp0Kf9x-WqzQG-ksCF6H3eo%26e%3D&a
> mp;data=02%7C01%7Cmonica.beckwith%40microsoft.com%7C907a0fd42b2d4b0b7e
> 0808d82fe99ab4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6373120276
> 51961479&sdata=VBONdqiyV6b7U%2Bqeami9xMgoP7u0qZHyX75AgHknXPA%3D&am
> p;reserved=0
> Webrev: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__nam06.safelinks.p
> rotection.outlook.com_-3Furl-3Dhttps-253A-252F-252Furld&d=DwIGaQ&c=nKj
> Wec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=uB
> 6tOAbHkzy_1rd_01j5dBADE-1lSlMJOz__BC-mmRw&s=uW7I8hTNYFXMAU4Z0U21Vrlu4O
> KfV0bP5ZBUpw5oIYk&e= 
> efense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__nam06.safelinks.prote
> ction.outlook.com_-3Furl-3Dhttps-3A-252F-252Fcr.openjdk.java.net-252F-
> 7Embeckwit-252F8248663-252Fwebrev.00-252F-26amp-3Bdata-3D02-257C01-257
> CMonica.Beckwith-2540microsoft.com-257C35f78927e915431fbf4d08d829bfff9
> d-257C72f988bf86f141af91ab2d7cd011db47-257C1-257C0-257C637305251886976
> 662-26amp-3Bsdata-3D28VwNHmLsoJcJRJ1OjBNH154-252BRB4QADUJHGz2Eh5M-252B
> k-253D-26amp-3Breserved-3D0%26d%3DDwIFAg%26c%3DnKjWec2b6R0mOyPaz7xtfQ%
> 26r%3DgW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk%26m%3DVRH-lUr10_r9nl
> ZWYqA0RgBcfPqzSx1Pz12OUdX6TQc%26s%3DFIrIXam-q51NnhIUlid_07RYh5O2xdtG6M
> Hz_uSxCro%26e%3D&data=02%7C01%7Cmonica.beckwith%40microsoft.com%7C
> 907a0fd42b2d4b0b7e0808d82fe99ab4%7C72f988bf86f141af91ab2d7cd011db47%7C
> 1%7C0%7C637312027651961479&sdata=Zg1MKDVEMMjsfeC5LXf6EI7d37Gg1f%2B
> zYzaPXYAdhDM%3D&reserved=0
> 
> Thanks,
> Monica
> 