[aarch64-port-dev ] RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic

[Yangfei (Felix)]

Hi,

> -----Original Message-----
> From: Andrew Haley [mailto:aph at redhat.com]
> Sent: Tuesday, August 4, 2020 6:27 PM
> To: Yangfei (Felix) <felix.yang at huawei.com>; hotspot-runtime-
> dev at openjdk.java.net
> Cc: aarch64-port-dev at openjdk.java.net
> Subject: Re: RFR: 8165404: AArch64: Implement SHA512 accelerator/intrinsic
> 
> On 8/3/20 2:18 AM, Yangfei (Felix) wrote:
> > OK.  I simply comment out the following code changes in
> vm_version_aarch64.cpp:
> >
> >  393   if (UseSHA && (auxv & HWCAP_SHA512)) {
> >  394     // Do not auto-enable UseSHA512Intrinsics until it has been fully
> tested on hardware
> >  395     // if (FLAG_IS_DEFAULT(UseSHA512Intrinsics)) {
> >  396       // FLAG_SET_DEFAULT(UseSHA512Intrinsics, true);
> >  397     // }
> >  398   } else if (UseSHA512Intrinsics) {
> >
> > Once this has been fully tested on real hardware, it will be easy to auto-
> enable.
> >
> > New webrev: http://cr.openjdk.java.net/~fyang/8165404/webrev.01/
> 
> Looks good, thanks.

Thanks for reviewing this.

> My apologies, there is another thing I should have mentioned: please add
> test cases for the new instructions to aarch64-asmtest.py and regenerate the
> code between
> 
> // BEGIN  Generated code -- do not edit
> // Generated by aarch64-asmtest.py
> 
> and
> 
> // END  Generated code -- do not edit
> 
> I'm trying to be more strict about making sure all of the instructions get
> tested.

Sure.  I have added tests for sha512 crypto instructions in this script and regenerated the code. 
Tier1-3 tested with an aarch64 fastdebug build on my aarch64 linux host to cover this part. 
Updated webrev: http://cr.openjdk.java.net/~fyang/8165404/webrev.02/ 
Is it OK?

Felix