[aarch64-port-dev ] RFR(XS) 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply

[Bernhard Urban-Forster]

Hello,

can someone sponsor this change please?

Webrev: http://cr.openjdk.java.net/~burban/8248816/


Thank you,
-Bernhard

________________________________________
From: Bernhard Urban-Forster <beurba at microsoft.com>
Sent: Friday, July 31, 2020 11:26
To: Andrew Haley; hotspot-dev Source Developers; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: [aarch64-port-dev ] RFR(XS) 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply

Thank you for the review Andrew. I've updated the Reviewed-By line in the Webrev:
http://cr.openjdk.java.net/~burban/8248816/


-Bernhard

________________________________________
From: Andrew Haley <aph at redhat.com>
Sent: Thursday, July 30, 2020 19:14
To: Bernhard Urban-Forster; hotspot-dev Source Developers; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: [aarch64-port-dev ] RFR(XS) 8248816: C1: Fix signature conflict in LIRGenerator::strength_reduce_multiply

On 30/07/2020 14:11, Bernhard Urban-Forster wrote:
> Hi all,
>
> this is a small fixup: the declaration of `strength_reduce_multiply` uses a `jint` for the parameter `constant` [1], but some backends were using `int` instead.
>
> JBS: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8248816&data=02%7C01%7Cbeurba%40microsoft.com%7C5527aeead1ce44e1b67e08d834ac03c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637317260684765118&sdata=28A9Rb7tzDC0rGgUJM6hQglZxzRmKBPtqEnXEbWYxWM%3D&reserved=0
> Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2F8248816%2F&data=02%7C01%7Cbeurba%40microsoft.com%7C5527aeead1ce44e1b67e08d834ac03c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637317260684765118&sdata=trUG1lHI%2F4CONPNFZQfZAai336f6vGfmsvbX5QTMLMs%3D&reserved=0

OK.

--
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=02%7C01%7Cbeurba%40microsoft.com%7C5527aeead1ce44e1b67e08d834ac03c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637317260684765118&sdata=gNegxAEKj64zz3OQP0I18hLpqIaABB7WX0yqWo4%2F4V0%3D&reserved=0>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=02%7C01%7Cbeurba%40microsoft.com%7C5527aeead1ce44e1b67e08d834ac03c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637317260684765118&sdata=NYh2gNU6IIcZa4NW8eP173%2FoXpstoVF%2B02dFZsYTFzY%3D&reserved=0
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671