[aarch64-port-dev ] 8248238: Implementation of JEP: Windows AArch64 Support

[Bernhard Urban-Forster]

Alas my changes do break a --disable-precompiled-headers build. That's the missing bit:

--- a/src/hotspot/cpu/aarch64/register_aarch64.hpp
+++ b/src/hotspot/cpu/aarch64/register_aarch64.hpp
@@ -27,6 +27,7 @@
 #define CPU_AARCH64_REGISTER_AARCH64_HPP

 #include "asm/register.hpp"
+#include "utilities/powerOfTwo.hpp"

 class VMRegImpl;
 typedef VMRegImpl* VMReg;




Updated webrev: http://cr.openjdk.java.net/~burban/8248238/webrev.03/


Cheers,
-Bernhard

________________________________________
From: Bernhard Urban-Forster <beurba at microsoft.com>
Sent: Saturday, August 22, 2020 00:13
To: Aleksey Shipilev; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: [aarch64-port-dev ] 8248238: Implementation of JEP: Windows AArch64 Support

Hey Aleksey,

thanks for your comments!


>  *) make/autoconf/jvm-features.m4: are we sure Shenandoah does not work with Windows AArch64? I
> don't think there should be a problem with it. I also see there are Shenandoah-related changes
> elsewhere, so I assume it was built at some time?

Shenandoah (and ZGC for what it's worth) do work out of the box on Windows AArch64. We didn't test them extensively though and did intentionally not included them in the JEP to reduce the test surface for now.
Monica has opened a bug for both GCs: https://bugs.openjdk.java.net/browse/JDK-8252114


>  *) src/hotspot/cpu/aarch64/aarch64.ad: are these needed?
>
>  993 #include "gc/shared/barrierSet.hpp"
>  994 #include "gc/shared/barrierSetAssembler.hpp"

Good catch, they are not needed. Removed.


>  *) src/hotspot/share/runtime/vm_version.hpp: new includes in the .hpp file?
> Wouldn't it be better to do them in the relevant compilation units?
>
>  28 #include "memory/allocation.hpp"
>  29 #include "utilities/ostream.hpp"

Apparently they aren't needed too, hu. Removed.


Tested the build on Linux AArch64 and Windows AArch64.

Updated Webrev: http://cr.openjdk.java.net/~burban/8248238/webrev.02/

Thank you,
-Bernhard