[aarch64-port-dev ] RFR(S): 8236992: AArch64: remove redundant load_klass in itable stub
Nick Gasson
nick.gasson at arm.com
Thu Jan 16 10:04:51 UTC 2020
Hi Andrew,
>
> This comment is a "what" but not a "why":
>
> - // Most registers are in use; we'll use r16, rmethod, r10, r11
> + // This stub is called from compiled code which has no callee-saved registers.
>
> It might be better to say that all registers except args are free at
> this point.
>
> The lack of such a comment once cause Andrew Dinn and me to spend a
> week debugging. :-(
>
Yes, good point. OK to push if I change the comment to this?
// This stub is called from compiled code which has no callee-saved
registers,
// so all registers except arguments are free at this point.
Thanks,
Nick
More information about the aarch64-port-dev
mailing list