[aarch64-port-dev ] RFR: 8237512: AArch64: aarch64TestHook leaks a BufferBlob

[Andrew Haley]

On 1/20/20 10:29 AM, Andrew Dinn wrote:
> On 20/01/2020 10:07, Nick Gasson wrote:
>> On 20/01/2020 17:54, Andrew Haley wrote:
>>>
>>> Please check the copyright dates: the RH copyright might want updating,
>>> but the Oracle one probably doesn't.
>>>
>>
>> I'm not sure what the rules are for this: I bumped the copyright year in
>> the first line of each file I modified to 2020, as this seems to be what
>> everyone else does. Is aarch64Test.cpp missing an "Oracle and/or its
>> affiliates" copyright line?
>
> Well, I'm confused by this. As I understand it the Oracle copyright is
> supposed to be up to date with whatever is the latest change while the
> Red Hat copyright does not need to be kept up to date

I have never seen this rule before. What is your source for it? But
in any case, the Oracle copyright message here is because this file was
originally derived from Oracle code; the code being patches is by us.

> (in which case before your patch the other files were in the
> erroneous state of having an Oracle copyright that was behind the
> Red Hat one). However, Andrew's comment does not seem to support my
> view.
>
> Perhaps he or someone else could clarify? At which point I will be happy
> to push your patch with whatever copyrights are appropriate.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671