[aarch64-port-dev ] RFR: 8248414: AArch64: Remove uses of long and unsigned long ints

[Andrew Dinn]

Hi Andrew,

On 10/07/2020 10:09, Andrew Haley wrote:
> http://cr.openjdk.java.net/~aph/8248414-3/
> 
> Incremental diff from the first version at:
> 
> http://cr.openjdk.java.net/~aph/8248414-3-incremental.diff

The patch looks fine except for this one change at assembler_aarch64.hpp:673

   void f(unsigned val, int msb) {
     current->f(val, msb, msb);
   }
-  void sf(long val, int msb, int lsb) {
+  void sf(uint64_t val, int msb, int lsb) {
     current->sf(val, msb, lsb);
   }

I think val ought to be declared as int64_t.

regards,


Andrew Dinn
-----------
Red Hat Distinguished Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill