[aarch64-port-dev ] RFR(XS) 8248681: AArch64: MSVC doesn't support __PRETTY_FUNCTION__

David Holmes david.holmes at oracle.com
Tue Jul 14 23:52:22 UTC 2020


Hi Monica,

On 15/07/2020 7:11 am, Monica Beckwith wrote:
> Hi all,
> 
> Please review the change for MSVC, which doesn't have the __PRETTY_FUNCTION__ macro.
> I have instead added __FUNCSIG__ within appropriate #ifdef and also added the following comments:
> 
> +// Microsoft's MSVC team thinks that the __FUNCSIG__ is approximately (sympathy for calling conventions) equivalent to __PRETTY_FUNCTION__
> +// Also, from the Clang patch: "It is very similar to GCC's PRETTY_FUNCTION, except it prints the calling convention."
> +// https://reviews.llvm.org/D3311
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8248681
> Webrev: http://cr.openjdk.java.net/~mbeckwit/8248681/webrev.00/

Sorry but this is definitely part of the Windows-Aarch64 port and as 
such should be done under the implementation of the JEP, once targeted.

If the intent was to push this to the aarch64-port repo then please 
update the bug with the repo-aarch64-port release values.

Thanks,
David

> Regards,
> Monica
> 
> 


More information about the aarch64-port-dev mailing list