[aarch64-port-dev ] RFR(XS) 8248681: AArch64: MSVC doesn't support __PRETTY_FUNCTION__

[Kim Barrett]

> On Jul 14, 2020, at 7:18 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Jul 14, 2020, at 5:11 PM, Monica Beckwith <Monica.Beckwith at microsoft.com> wrote:
>> 
>> Hi all,
>> 
>> Please review the change for MSVC, which doesn't have the __PRETTY_FUNCTION__ macro. 
>> I have instead added __FUNCSIG__ within appropriate #ifdef and also added the following comments:
>> 
>> +// Microsoft's MSVC team thinks that the __FUNCSIG__ is approximately (sympathy for calling conventions) equivalent to __PRETTY_FUNCTION__
>> +// Also, from the Clang patch: "It is very similar to GCC's PRETTY_FUNCTION, except it prints the calling convention."
>> +// https://reviews.llvm.org/D3311
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8248681
>> Webrev: http://cr.openjdk.java.net/~mbeckwit/8248681/webrev.00/
>> 
>> Regards,
>> Monica
> 
> Not so much a review as a comment / suggested alternative.

Thinking about this some more, because of the toolchain-specific
conditionalization I think I would argue against this change in this
form, even if it were part of an eventual windows-aarch64 targeted
port. I really don't think the proposed change should be made to
mainline at this time. That is a review rather than just a comment.