[aarch64-port-dev ] RFR(S): 8248676: AArch64: Add workaround for LITable constructor

[Ludovic Henry]

Hi Andrew,

A quick follow-up on that patch. Is there anything you would like to see done differently?

Thank you,

--
Lidovic

________________________________________
From: Ludovic Henry <luhenry at microsoft.com>
Sent: Friday, July 10, 2020 10:58
To: Andrew Haley; hotspot-compiler-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: [aarch64-port-dev ] RFR(S): 8248676: AArch64: Add workaround for LITable constructor

Hi Andrew,

I uploaded a new webrev following your review.

Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248676%2Fwebrev.01%2F&data=02%7C01%7Cluhenry%40microsoft.com%7Cf0344ec5e0284918c41308d824fae260%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637300007247824629&sdata=XUa2v10K2zvoqA7OD7BstRYrRc85ewchBD3YRkdbqDc%3D&reserved=0
Testing: jtreg:test/hotspot/jtreg:tier1, jtreg:test/jdk:tier1, jtreg:test/jdk:tier2, jtreg:test/langtools on Linux-AArch64, no regressions

Thank you,

________________________________________
From: Andrew Haley <aph at redhat.com>
Sent: Friday, July 10, 2020 01:10
To: Ludovic Henry; hotspot-compiler-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: [aarch64-port-dev ] RFR(S): 8248676: AArch64: Add workaround for LITable constructor

On 09/07/2020 21:31, Ludovic Henry wrote:
> JBS: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8248676&data=02%7C01%7Cluhenry%40microsoft.com%7Cf0344ec5e0284918c41308d824fae260%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637300007247824629&sdata=3zArU%2F%2FmsCilK%2F8wIIsxEtp4bXd%2BEn0ZOkQVODcRyDA%3D&reserved=0
> Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248676%2Fwebrev.00%2F&data=02%7C01%7Cluhenry%40microsoft.com%7Cf0344ec5e0284918c41308d824fae260%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637300007247824629&sdata=cyCZTT5%2BIRkbms%2BI5jpWhpH%2BsdQuAPXVppnJ0dNsDh8%3D&reserved=0
> Testing: jtreg:test/hotspot/jtreg:tier1, jtreg:test/jdk:tier1, jtreg:test/jdk:tier2, jtreg:test/langtools on Linux-AArch64, no regressions.
>
> This small fix is in the context of the larger support for Windows-AArch64. The attribute `__attribute__ ((constructor))` is not supported by MSVC, and the documented workaround is to allocate an empty static struct with a constructor. This patch only applies this workaround when compiling on Windows, and leaves other platforms unchanged.

Please take out the #ifdef WINDOWS: we can use portable C++ here on all
platforms. Thanks,

--
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=02%7C01%7Cluhenry%40microsoft.com%7Cf0344ec5e0284918c41308d824fae260%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637300007247824629&sdata=%2FVEaURXjnDXwjVj2i5oci6ZH7ZXKm1a4QGsXY0OzPco%3D&reserved=0>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=02%7C01%7Cluhenry%40microsoft.com%7Cf0344ec5e0284918c41308d824fae260%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637300007247834623&sdata=8HQN5TP4Kbxqji6PEue7wk0Tirpc7qRMOyGTnp0jBm0%3D&reserved=0
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671