[aarch64-port-dev ] RFR(XS) 8248681: AArch64: MSVC doesn't support __PRETTY_FUNCTION__

[Monica Beckwith]

Hello everyone - 

Here's some background on this and similar RFRs that we are sending out ahead of the `repo-aarch64-port` tagged RFRs:

- we are sending these right now to encourage discussions around the changes that we had initially guarded by appropriate ifdefs since we were modifying shared code for the default use-case (such as having GCC specific macros for aarch64). 
- for this particular one, I too thought that dropping __PRETTY_FUNCTION__ was a better option. (So, thank you both for suggesting that)
- there are just 2 more cleanups to `cpu/aarch64/*` where MSVC keywords or macro names are employed, and I was hoping to send those out shortly.

So, @Andrew Haley, let us know if we should stop and wait for all existing cleanups to get pushed to tip. Or if we should send out the last 2 (as mentioned above) and then sync and start pushing our Windows + AArch64 specific changes to `repo-aarch64-port.`

-Monica



-----Original Message-----
From: Kim Barrett <kim.barrett at oracle.com> 
Sent: Wednesday, July 15, 2020 5:48 AM
To: Andrew Haley <aph at redhat.com>
Cc: Monica Beckwith <Monica.Beckwith at microsoft.com>; aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>; openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
Subject: Re: [aarch64-port-dev ] RFR(XS) 8248681: AArch64: MSVC doesn't support __PRETTY_FUNCTION__

> On Jul 15, 2020, at 4:24 AM, Andrew Haley <aph at redhat.com> wrote:
> 
> On 15/07/2020 00:18, Kim Barrett wrote:
>> Of course, this is currently the only use of __PRETTY_FUNCTION__ in 
>> all of HotSpot, so that might be considered excessive overhead.  But 
>> if we had such a macro it would simplify (and so perhaps encourage) 
>> the use of this feature.
> 
> I don't think we need __PRETTY_FUNCTION__ here. Anyway, I'm leaning 
> towards David Holmes' position that this is AArch64/Windows specific,

Eliminating the only use of __PRETTY_FUNCTION__ also seems like a good solution, and doesn’t seem aarch64/windows-specific to me.