[aarch64-port-dev ] RFR(XS) 8248671: AArch64: Remove unused variables

[Bernhard Urban-Forster]

Hello David,

here is a webrev with a proper mercurial changeset included: http://cr.openjdk.java.net/~burban/8248671_hg_export/

Thank you,
-Bernhard

________________________________________
From: David Holmes <david.holmes at oracle.com>
Sent: Tuesday, July 21, 2020 04:25
To: Bernhard Urban-Forster; aarch64-port-dev at openjdk.java.net; hotspot-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: RFR(XS) 8248671: AArch64: Remove unused variables

Hi Bernhard,

On 20/07/2020 11:31 pm, Bernhard Urban-Forster wrote:
> Hello Andrew and David,
>
> is this fine to push? If yes, I need a someone to do that for me as I'm not a committer.

Can you generate the final changeset please, with proper commit message
[1] so that whomever sponsors this can do a direct "hg import".

Thanks,
David

[1] https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fopenjdk.java.net%2Fguide%2FproducingChangeset.html&data=02%7C01%7Cbeurba%40microsoft.com%7C5826e4957e42479469ed08d82d1db4d1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637308952896746440&sdata=XTQJoOJnM3arad15ytcodu4%2BnPRXnYcSSVJnRz35ekk%3D&reserved=0

>
> Thank you,
> -Bernhard
>
> ________________________________________
> From: Bernhard Urban-Forster <beurba at microsoft.com>
> Sent: Monday, July 13, 2020 16:03
> To: David Holmes; aarch64-port-dev at openjdk.java.net; hotspot-dev at openjdk.java.net; hotspot-compiler-dev at openjdk.java.net
> Cc: openjdk-aarch64
> Subject: RE: RFR(XS) 8248671: AArch64: Remove unused variables
>
> Thank you for your review Andrew and David.
>
> Here is the webrev based on https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhg.openjdk.java.net%2Fjdk%2Fjdk%2F&data=02%7C01%7Cbeurba%40microsoft.com%7C5826e4957e42479469ed08d82d1db4d1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637308952896746440&sdata=Ul6pqOngjqozX%2FYpZXH3TbjIw9O27jouN47NTLhvHp4%3D&reserved=0:
>
> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2F8248671_hg%2F&data=02%7C01%7Cbeurba%40microsoft.com%7C5826e4957e42479469ed08d82d1db4d1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637308952896746440&sdata=pa6O7bS78Q3hOowXCmAAbRY%2BI4H%2Bnk7V%2BErM9q%2BCYWc%3D&reserved=0
>
>
> Thanks,
> -Bernhard
>
>> -----Original Message-----
>> From: David Holmes <david.holmes at oracle.com>
>> Sent: Monday, July 13, 2020 6:08 AM
>> To: Bernhard Urban-Forster <beurba at microsoft.com>; aarch64-port-
>> dev at openjdk.java.net; hotspot-dev at openjdk.java.net; hotspot-compiler-
>> dev at openjdk.java.net
>> Subject: Re: RFR(XS) 8248671: AArch64: Remove unused variables
>>
>> Hi Bernhard,
>>
>> On 10/07/2020 7:08 am, Bernhard Urban-Forster wrote:
>>> Hello everyone,
>>>
>>>
>>> please review this change:
>>>
>>> JBS:
>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
>>> .openjdk.java.net%2Fbrowse%2FJDK-
>> 8248671&data=02%7C01%7Cbeurba%40m
>>>
>> icrosoft.com%7Cfa08ce93e8d44b4f38a708d826e296ed%7C72f988bf86f141af
>> 91ab
>>>
>> 2d7cd011db47%7C1%7C0%7C637302101922573034&sdata=Bv6Fsw104
>> ZizId5EdC
>>> %2BTnV8DrJCJyQzVk9ht6rWjLMw%3D&reserved=0
>>> Webrev:
>>> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.open
>>> jdk.java.net%2F~burban%2F8248671_unused-
>> vars%2F&data=02%7C01%7Cbeu
>>>
>> rba%40microsoft.com%7Cfa08ce93e8d44b4f38a708d826e296ed%7C72f988bf
>> 86f14
>>>
>> 1af91ab2d7cd011db47%7C1%7C0%7C637302101922573034&sdata=X7
>> 7Ri2iWLkm
>>> %2FOSmdP9HyEWEwMA7rO%2BM6oKVRAg4zHGQ%3D&reserved=0
>>>
>>> We found this issue while bringing up Windows+AArch64 support for
>> HotSpot. The Microsoft toolchain (MSVC) seems to be slightly more pedantic
>> than GCC.
>>
>> Looks good and trivial.
>>
>> But could I request that webrevs/patches for mainline be generated against the
>> mainline hg repository rather than the git mirror.
>>
>> Thanks,
>> David
>>
>>>
>>> Thanks,
>>> -Bernhard
>>>