[aarch64-port-dev ] RFR/Feedback(XS) 8248668: AArch64: Avoid MIN/MAX macros when using MSVC

Monica Beckwith Monica.Beckwith at microsoft.com
Thu Jul 23 21:05:43 UTC 2020


Thanks, Thomas and Kim, I have added you both in the 'reviewed-by' field and here's the new webrev: http://cr.openjdk.java.net/~mbeckwit/8248668/webrev.01/
I am also linking the bug id here again (sorry that our mail client obfuscates links): https://bugs.openjdk.java.net/browse/JDK-8248668.

Can someone please help push it?

Regards,

Monica

-----Original Message-----
From: Kim Barrett <kim.barrett at oracle.com> 
Sent: Friday, July 17, 2020 12:44 PM
To: Monica Beckwith <Monica.Beckwith at microsoft.com>
Cc: aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>; openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
Subject: Re: RFR/Feedback(XS) 8248668: AArch64: Avoid MIN/MAX macros when using MSVC

> On Jul 16, 2020, at 7:25 PM, Monica Beckwith <Monica.Beckwith at microsoft.com> wrote:
> 
> On Windows, we employ min/max as macros ��, hence we have made a few changes to appropriate shared sources:
> 
> JBS: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8248668&data=02%7C01%7CMonica.Beckwith%40microsoft.com%7C565ae080eb8b45304a9108d82a790df5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637306046696535165&sdata=fYB0i9oIVspGlFwehtcRP5a9raDvYoy7nL5dAJ0yej0%3D&reserved=0 
> Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~mbeckwit%2F8248668%2Fwebrev.00%2F&data=02%7C01%7CMonica.Beckwith%40microsoft.com%7C565ae080eb8b45304a9108d82a790df5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637306046696535165&sdata=g6SakFcYU3bSBE5WY6v%2F4j1mm5Ec12H1DhjZ%2BPR%2B1ao%3D&reserved=0 
> 
> Regards,
> Monica

Looks good.



More information about the aarch64-port-dev mailing list