[aarch64-port-dev ] RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC

[David Holmes]

On 25/07/2020 1:26 am, Derek White wrote:
> Hi Monica,
> 
> Looks good!
> 
> Style comment - I'm not sure if the comments about MSVC in c2_MacroAssembler_aarch64.cpp and macroAssembler_aarch64.hpp are strictly necessary, but I don't have a strong opinion.

Agreed. Such comments explain a change but then lose all context.

Thanks,
David

> - Derek
> 
> -----Original Message-----
> From: aarch64-port-dev <aarch64-port-dev-retn at openjdk.java.net> On Behalf Of Monica Beckwith
> Sent: Friday, July 24, 2020 11:10 AM
> To: aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
> Cc: openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
> Subject: [EXT] Re: [aarch64-port-dev ] RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hello all - could I please get feedback on the following changes?
> 
> Copying clean links here again:
> JBS: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8248663&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=VRH-lUr10_r9nlZWYqA0RgBcfPqzSx1Pz12OUdX6TQc&s=-1BKo7dfMxAqI0c80NeOgXxY4Kig4HV6N_342REuHTc&e=
> Webrev: https://urldefense.proofpoint.com/v2/url?u=https-3A__cr.openjdk.java.net_-7Embeckwit_8248663_webrev.00_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=VRH-lUr10_r9nlZWYqA0RgBcfPqzSx1Pz12OUdX6TQc&s=FDH2O5mbnaWupPL9AiRQqpDl1glFLtf1vP02BQvfmXM&e=
> 
> Thanks,
> Monica
> 
> 
> -----Original Message-----
> From: Monica Beckwith <Monica.Beckwith at microsoft.com>
> Sent: Thursday, July 16, 2020 2:40 PM
> To: aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
> Cc: openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
> Subject: RFR/Feedback(S) 8248663: AArch64: Avoid existing macros/keywords of MSVC
> 
> These changes are concerning specific macro names or keywords used by MSVC. E.g. `mvn,` `DIFFERENCE` and `far.` We are proposing to change those in the shared code.
> 
> JBS: https://urldefense.proofpoint.com/v2/url?u=https-3A__nam06.safelinks.protection.outlook.com_-3Furl-3Dhttps-253A-252F-252Fbugs.openjdk.java.net-252Fbrowse-252FJDK-2D8248663-26amp-3Bdata-3D02-257C01-257CMonica.Beckwith-2540microsoft.com-257C35f78927e915431fbf4d08d829bfff9d-257C72f988bf86f141af91ab2d7cd011db47-257C1-257C0-257C637305251886976662-26amp-3Bsdata-3DjGxT7lMPEEg7iJPgoflgEByvHnuZEof-252BBqPrGfQhulg-253D-26amp-3Breserved-3D0&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=VRH-lUr10_r9nlZWYqA0RgBcfPqzSx1Pz12OUdX6TQc&s=6CkQlp-iwC2nuFgVxfwZjp0Kf9x-WqzQG-ksCF6H3eo&e=
> Webrev: https://urldefense.proofpoint.com/v2/url?u=https-3A__nam06.safelinks.protection.outlook.com_-3Furl-3Dhttps-3A-252F-252Fcr.openjdk.java.net-252F-7Embeckwit-252F8248663-252Fwebrev.00-252F-26amp-3Bdata-3D02-257C01-257CMonica.Beckwith-2540microsoft.com-257C35f78927e915431fbf4d08d829bfff9d-257C72f988bf86f141af91ab2d7cd011db47-257C1-257C0-257C637305251886976662-26amp-3Bsdata-3D28VwNHmLsoJcJRJ1OjBNH154-252BRB4QADUJHGz2Eh5M-252Bk-253D-26amp-3Breserved-3D0&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=gW0hANMfJfyELYt_X2mceubwzCNjT0vmaU97kngYUJk&m=VRH-lUr10_r9nlZWYqA0RgBcfPqzSx1Pz12OUdX6TQc&s=FIrIXam-q51NnhIUlid_07RYh5O2xdtG6MHz_uSxCro&e=
> 
> Thanks,
> Monica
>