[aarch64-port-dev ] RFR(S): 8248676: AArch64: Add workaround for LITable constructor

[Ludovic Henry]

> But I think we should now move to integrating all of your Windows-
> specific changes in the jdk-windows tree and then we'll put together a
> Big Windows Patch and push that to mainline. I don't think it'll take
> long. Let's just get it done!

Sounds good to me, let's do that then.

________________________________________
From: Andrew Haley <aph at redhat.com>
Sent: Saturday, July 25, 2020 08:30
To: Ludovic Henry; hotspot-compiler-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64
Subject: Re: [aarch64-port-dev ] RFR(S): 8248676: AArch64: Add workaround for LITable constructor

On 24/07/2020 17:02, Ludovic Henry wrote:

> Are you saying that you would like this change to land into
> `aarch64-port/jdk-windows` before getting into jdk/jdk? This change
> doesn't strike me as windows-aarch64 specific and is in line with
> general removal of GCC-specific code (similarly to the LP64 vs
> LLP64, or JDK-8248666).
>
> Webrev: https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248676%2Fwebrev.01&data=02%7C01%7Cluhenry%40microsoft.com%7Cac4df4162a664138e45308d830afacd7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637312878365016046&sdata=9994EG19jrHKN5ITL4unJ4E4UeA5g%2FEG0w%2BoRlJaIGA%3D&reserved=0

You make a good point. I didn't want to get integer type cleanups
mixed up with the Windows import, so I wanted to do them first.

I think there was a general feeling, expressed by Dalibor, the leader
of the Porters' Group, that the Windows changes should be integrated
into the https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fhg.openjdk.java.net%2Faarch64-port%2Fjdk-windows%2F&data=02%7C01%7Cluhenry%40microsoft.com%7Cac4df4162a664138e45308d830afacd7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637312878365026037&sdata=GFvB2M2i7Dfgsxi%2B61JpdBatSAORz%2Bt1TQwpG06eBfY%3D&reserved=0 tree.

This change is marginal, IMO. Clearly it's a GCC-ism, so I won't
refuse it being cleaned up in mainline if you want.

But I think we should now move to integrating all of your Windows-
specific changes in the jdk-windows tree and then we'll put together a
Big Windows Patch and push that to mainline. I don't think it'll take
long. Let's just get it done!

--
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=02%7C01%7Cluhenry%40microsoft.com%7Cac4df4162a664138e45308d830afacd7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637312878365026037&sdata=tLRvd1De7n64g7NaYF7aGeYtbZZt61tG1hpWK0cJHG0%3D&reserved=0>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=02%7C01%7Cluhenry%40microsoft.com%7Cac4df4162a664138e45308d830afacd7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637312878365026037&sdata=S%2FaJkySd0c1SlT1b6XWYoAJQrkI6Vzm2X%2Fd44oEyaUw%3D&reserved=0
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671