[aarch64-port-dev ] [8] RFR (XS) 8246482: Build failures with +JFR -PCH

[Andrew Haley]

On 03/06/2020 18:08, Aleksey Shipilev wrote:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8246482
> 
> This build failure is AArch64+JFR specific:
> 
> .../hotspot/src/share/vm/jfr/writers/jfrEncoders.hpp: In static member function 'static size_t
> BigEndianEncoderImpl::encode(T, u1*)':
> .../hotspot/src/share/vm/jfr/writers/jfrEncoders.hpp:91:8: error: 'Bytes' has not been declared
>         Bytes::put_Java_u2(dest, value);
>         ^~~~~
> 
> Fix:
> 
> diff -r 1ac56046129c src/share/vm/jfr/writers/jfrEncoders.hpp
> --- a/src/share/vm/jfr/writers/jfrEncoders.hpp  Tue May 26 03:05:00 2020 +0100
> +++ b/src/share/vm/jfr/writers/jfrEncoders.hpp  Wed Jun 03 13:03:31 2020 -0400
> @@ -43,6 +43,9 @@
>  #ifdef TARGET_ARCH_ppc
>  # include "bytes_ppc.hpp"
>  #endif
> +#ifdef TARGET_ARCH_aarch64
> +# include "bytes_aarch64.hpp"
> +#endif
> 
>  //
>  // The Encoding policy prescribes a template
> 
> There is another one that is JFR+Shenandoah specific, it would come with a merge:
>   https://mail.openjdk.java.net/pipermail/shenandoah-dev/2020-June/012413.html
>   https://hg.openjdk.java.net/shenandoah/jdk8/hotspot/rev/e16a3f855bf3
> 
> Testing: aarch64 build with +JFR -PCH

OK

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671