[aarch64-port-dev ] [EXTERNAL] Re: OpenJDK extension to AArch64 and Windows

Monica Beckwith Monica.Beckwith at microsoft.com
Thu Jun 25 14:46:50 UTC 2020


Hello all,

Here's my reasoning for this not to warrant a JEP:

	• We are extending the `AArch64 Port Project` [1] while keeping its essence: "It is hoped that this project will eventually be able to support operating systems other than GNU/Linux, and welcomes contributors with the necessary expertise." And we hope to be contributors to `aarch64-port.`
		• The OpenJDK team at Microsoft understands that this extension is building on the fantastic work of giants.
		• The new platform code by itself is confined to 15 (+4) files (1222 lines (+322)). To us, this is a small, clean enough footprint to not stir up the JEP process on size/complexity grounds.
		• All the other files are bridging/building support in existing files. We have tried to minimize our ripple, and you will probably notice that some shared files have a single line change to them. 
		• Nonetheless, they have to be reviewed, and we appreciate the time folks will be spending on this.
		• We sent the initial patches to `aarch64-port-dev` and `hotspot-runtime-dev.` And we were thankfully and rightfully guided to `build-dev.` We will continue to work with all to support changes to the all of the patches [2].	 
	• The OpenJDK team at Microsoft is fully invested in maintaining the patches in the long term. We are happy to work through any improvements to them, splitting them up further if needed, etc.
	• I also envision that our support and maintenance will spread beyond the windows+aarch64 combo into linux+aarch64 and windows+x86-64
		• As you can tell from the patches, we touch all those platforms, since our goal was/is not only to push out the new platform support but also to support/cleanup/coalesce all that we touch.

As mentioned in my initial email, our P2 patch will need some reworking with respect to R18 and we have been working together with AndrewH and AndrewD to deliver a fix. As you all know, AndrewH is also the lead for the `aarch64-port` project. 

Given the above, our preference is to continue working with the reviewers (as AndrewH has stated). I am positive that in the future, we will have many opportunities to collaborate via JEPs/projects.

Regards,
Monica
[1] https://openjdk.java.net/projects/aarch64-port/ 
[2] The team is aware + invested in the amount of testing that is needed to support all the platforms with the CI pipeline. With the initial patches/webrevs, we have provided the info and our coverage on those. I am happy to expand that as needed.





-----Original Message-----
From: Andrew Haley <aph at redhat.com> 
Sent: Thursday, June 25, 2020 3:29 AM
To: Alan Bateman <Alan.Bateman at oracle.com>; David Holmes <david.holmes at oracle.com>; Monica Beckwith <Monica.Beckwith at microsoft.com>; hotspot-runtime-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
Cc: openjdk-aarch64 <openjdk-aarch64 at microsoft.com>
Subject: [EXTERNAL] Re: [aarch64-port-dev ] OpenJDK extension to AArch64 and Windows

On 25/06/2020 08:39, Alan Bateman wrote:
> On 24/06/2020 23:34, David Holmes wrote:
>>
>> Are you proposing a new project to introduce this new port into the 
>> OpenJDK some time in the future?
>
> I think it will need a JEP at least. I could imagine doing some 
> cleanup in advance, maybe also improvements to support cross building 
> on Windows, to eliminate some of the noise from the patch.

If someone want to do the JEP bureaucracy that's fine by me, but in the meantime we'll try to get the AArch64 parts in shape so that the Windows import is simpler. In particular, we can get all of the register and integer type changes done.

--
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=02%7C01%7CMonica.Beckwith%40microsoft.com%7C707b458cc15f4e5c99a008d818e1c23d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637286705193417733&sdata=xXA5SVdtOunk3U%2BmuIPC4WIftC6uNhW4220i4c9%2FMUw%3D&reserved=0>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=02%7C01%7CMonica.Beckwith%40microsoft.com%7C707b458cc15f4e5c99a008d818e1c23d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637286705193417733&sdata=e5bM%2B%2BkSPuCHmje65EZUGDbMjNNVvwpbP%2Bd1Ga%2BZYpk%3D&reserved=0
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the aarch64-port-dev mailing list