[aarch64-port-dev ] RFR: Bulk integration from Shenandoah

[Andrew Hughes]

On 06/03/2020 17:49, Aleksey Shipilev wrote:
> On 3/6/20 6:22 PM, Roman Kennke wrote:
>> Changeset:
>> http://cr.openjdk.java.net/~rkennke/bulk-integration-2020-03-06/changesets.01
>>
>> Full webrev:
>> http://cr.openjdk.java.net/~rkennke/bulk-integration-2020-03-06/webrev.01/
> 
> This looks good to me.
> 
> Andrews need to concur before we can push :)
> 

These would be easier to review if the cumulative effect of the changes
could be more easily seen. I was going to suggest including the merge
changeset, but this doesn't appear to be a merge. Why are we not just
pushing these to aarch64/shenandoah-jdk8u as they are developed, rather
than waiting to do them all in bulk? Particularly as it's relatively
late in the development process for the April CPU.

Most of these seem to be Shenandoah-specific. The one that catches my
eye is:

8229919: Support JNI Critical functions in object pinning API on x86_32
platforms

This seems like it will introduce a behavioural deviation for those who
are not using Shenandoah, in comparison to vanilla 8u. Can you assure me
this is safe?

I do wonder if patches like this should be backported to upstream 8u &
11u, ahead of any proposed Shenandoah merge into those upstreams.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222