[aarch64-port-dev ] RFR(M): 8243392: Remodel CDS/Metaspace storage reservation

[Andrew Haley]

Hi,

In general, please wrap comment lines at 80 characters. Some of these lines
are too long to read.

On 5/7/20 3:21 PM, Thomas Stüfe wrote:


+  // Note: on AARCH64, if the code above does not find any good placement, we
+  // have no recurse. We return an empty space and the VM will exit.
   return ReservedSpace();

Spelling: "we have no recourse"

+    // We do this by reserving space for the ccs behind the archives. Note however that

Should be "below the archives", surely? Or is that "above"? Which is it?

+  bool use_requested_base = true; // Whether to use SharedBaseAddress as attach point.

What exactly is an "attach point" ? The phrase is used few times in
comments but never defined.

+//      class space according to CompressedClassSpaceSize. Its start address will be aligned to etaspace::reserve_alignment

"Metaspace"

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671